linux-kernel - Re: [PATCH v2] iio: Avoid multiple line dereference for mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220820131754.729d59a9@jic23-huawei>
Date:   Sat, 20 Aug 2022 13:17:54 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Joe Simmons-Talbott <joetalbott@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: Avoid multiple line dereference for mask

On Fri, 19 Aug 2022 14:20:12 -0400
Joe Simmons-Talbott <joetalbott@...il.com> wrote:

> Prefer lines > 80 characters over splitting dereferences across multiple
> lines. Reported by checkpatch.pl.
> 
> Signed-off-by: Joe Simmons-Talbott <joetalbott@...il.com>
Applied to the togreg branch of iio.git which will get pushed out initially
as testing for all the normal reasons...

Jonathan

> ---
> changes in v2:
> * Don't use a temporary variable.
> 
>  drivers/iio/industrialio-core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 67d3d01d2dac..d38623c046cc 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1303,8 +1303,7 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev,
>  
>  	ret = iio_device_add_info_mask_type_avail(indio_dev, chan,
>  						  IIO_SEPARATE,
> -						  &chan->
> -						  info_mask_separate_available);
> +						  &chan->info_mask_separate_available);
>  	if (ret < 0)
>  		return ret;
>  	attrcount += ret;
> @@ -1318,8 +1317,7 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev,
>  
>  	ret = iio_device_add_info_mask_type_avail(indio_dev, chan,
>  						  IIO_SHARED_BY_TYPE,
> -						  &chan->
> -						  info_mask_shared_by_type_available);
> +						  &chan->info_mask_shared_by_type_available);
>  	if (ret < 0)
>  		return ret;
>  	attrcount += ret;