linux-kernel - Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMysz=6NHq6tJcxHbm5vy4usVq2XEDp9q+ydmcHcqGw94A@mail.gmail.com>
Date:   Mon, 22 Aug 2022 11:05:39 +0200
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     kernel-janitors <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Muchun Song <songmuchun@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page_range()

On Mon, Aug 22, 2022 at 10:51 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> On 2022/8/22 16:25, Lukas Bulwahn wrote:
> > Commit a0e4f7b82610 ("mm/hugetlb: make detecting shared pte more reliable")
> > modifies copy_hugetlb_page_range() such that huge_ptep_get(dst_pte) and the
> > local variable dst_entry is not used explicitly in this function.
> >
> > Remove this unused local variable dst_entry in copy_hugetlb_page_range().
> > No functional change.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>
> LGTM. Thanks for your patch.
>
> Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
>
> BTW: I will send a v2 of that series soon. So the above commit id might change.
>

Feel free to just squash this code improvement into your next v2 patch.

Lukas