linux-kernel - Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5450a153-382d-7476-8674-4a615d08eebe@huawei.com>
Date:   Mon, 22 Aug 2022 17:21:45 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
CC:     kernel-janitors <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Muchun Song <songmuchun@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in
 copy_hugetlb_page_range()

On 2022/8/22 17:05, Lukas Bulwahn wrote:
> On Mon, Aug 22, 2022 at 10:51 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>>
>> On 2022/8/22 16:25, Lukas Bulwahn wrote:
>>> Commit a0e4f7b82610 ("mm/hugetlb: make detecting shared pte more reliable")
>>> modifies copy_hugetlb_page_range() such that huge_ptep_get(dst_pte) and the
>>> local variable dst_entry is not used explicitly in this function.
>>>
>>> Remove this unused local variable dst_entry in copy_hugetlb_page_range().
>>> No functional change.
>>>
>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>>
>> LGTM. Thanks for your patch.
>>
>> Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
>>
>> BTW: I will send a v2 of that series soon. So the above commit id might change.
>>
> 
> Feel free to just squash this code improvement into your next v2 patch.

Will do it. Thanks for your report and cleanup.

Thanks,
Miaohe Lin

> 
> Lukas
> .
>