linux-kernel - RE: [PATCH V2 0/7] i2c-imx-lpi2c: add IPG clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2022 11:49:59 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Clark Wang <xiaoning.wang@....com>, Peng Fan <peng.fan@....com>
Subject: RE: [PATCH V2 0/7] i2c-imx-lpi2c: add IPG clock

> From: Peng Fan (OSS) <peng.fan@....nxp.com>
> Sent: 2022年8月16日 20:55
> 
> V2:
>  use clk bulk API in driver to support backward compatibility.
>  Include a new patch, patch 1.
> 
> The i.MX LPI2C needs PER and IPG clock, not just PER or IPG clock.
> The current driver/dts/bindings use one CLK. Although it works with with
> upstream kernel, but it not match the hardware design. If IPG clock is disabled,
> the LPI2C will not work.
> 
> There are changes made to ARM32 i.MX7ULP dts, ARM64 i.MX8 dts,
> dt-bindings, and the lpi2c driver.
> 
> The driver is updated to use bulk clk API to avoid break backward compatibility.
> But it is hard to avoid dtbs_check pass, because the dts and binding update are
> in separate patches.

Reviewed-by: Dong Aisheng <aisheng.dong@....com>

Regards
Aisheng