lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d99ae719-f47d-e9fe-a8b4-cd77b4ea3503@huawei.com>
Date:   Tue, 23 Aug 2022 20:27:50 +0800
From:   Wu Bo <wubo40@...wei.com>
To:     Wenchao Hao <haowenchao22@...il.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Wenchao Hao <haowenchao@...wei.com>
Subject: Re: [PATCH] scsi: increase scsi device's iodone_cnt in scsi_timeout()

On 2022/8/16 0:43, Wenchao Hao wrote:
> The iodone_cnt might be less than iorequest_cnt because
> we did not increase the iodone_cnt when a command is done
> from timeout.
> 
> Signed-off-by: Wenchao Hao <haowenchao@...wei.com>
> ---
>   drivers/scsi/scsi_error.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 448748e3fba5..d21ae0090166 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -355,6 +355,7 @@ enum blk_eh_timer_return scsi_timeout(struct request *req)
>   		 */
>   		if (test_and_set_bit(SCMD_STATE_COMPLETE, &scmd->state))
>   			return BLK_EH_RESET_TIMER;
> +		atomic_inc(&scmd->device->iodone_cnt);
>   		if (scsi_abort_command(scmd) != SUCCESS) {
>   			set_host_byte(scmd, DID_TIME_OUT);
>   			scsi_eh_scmd_add(scmd);

Reviewed-by: Wu Bo <wubo40@...wei.com>
-- 
Wu Bo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ