linux-kernel - Re: [PATCH v1] ACPI: processor: Remove freq Qos request for all CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jH2B2UHVtpCo8w-F6y+gr70yni+WDwuJMLuC_M_tNxQA@mail.gmail.com>
Date:   Tue, 23 Aug 2022 14:26:22 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Riwen Lu <luriwen@...mail.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Zhang, Rui" <rui.zhang@...el.com>, Len Brown <lenb@...nel.org>,
        Jeremy Linton <jeremy.linton@....com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Riwen Lu <luriwen@...inos.cn>
Subject: Re: [PATCH v1] ACPI: processor: Remove freq Qos request for all CPUs

On Tue, Aug 23, 2022 at 9:44 AM Riwen Lu <luriwen@...mail.com> wrote:
>
> From: Riwen Lu <luriwen@...inos.cn>
>
> The freq Qos request would be removed repeatedly if the cpufreq policy
> relates to more than one CPU. Then, it would cause the "called for unknown
> object" warning.
>
> Remove the freq Qos request for each CPU relates to the cpufreq policy,
> instead of removing repeatedly for the last CPU of it.
>
> Fixes: a1bb46c36ce3 ("ACPI: processor: Add QoS requests for all CPUs")
> Reported-by: Jeremy Linton <Jeremy.Linton@....com>
> Signed-off-by: Riwen Lu <luriwen@...inos.cn>
> ---
>  drivers/acpi/processor_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
> index db6ac540e924..e534fd49a67e 100644
> --- a/drivers/acpi/processor_thermal.c
> +++ b/drivers/acpi/processor_thermal.c
> @@ -151,7 +151,7 @@ void acpi_thermal_cpufreq_exit(struct cpufreq_policy *policy)
>         unsigned int cpu;
>
>         for_each_cpu(cpu, policy->related_cpus) {
> -               struct acpi_processor *pr = per_cpu(processors, policy->cpu);
> +               struct acpi_processor *pr = per_cpu(processors, cpu);
>
>                 if (pr)
>                         freq_qos_remove_request(&pr->thermal_req);
> --

Thanks for fixing my mistake!

I've applied this one instead of the revert of commit 7fdc74da940d, as
6.0-rc material.