linux-kernel - Re: [PATCH -next] xfs: remove redundant else for clean code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwTjnM/vvzTKLQWk@magnolia>
Date:   Tue, 23 Aug 2022 07:26:36 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Zeng Heng <zengheng4@...wei.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] xfs: remove redundant else for clean code

On Tue, Aug 23, 2022 at 09:47:45AM +0800, Zeng Heng wrote:
> "else" is not generally useful after a return, so remove it for clean code.
> 
> There is no logical changes.
> 
> Signed-off-by: Zeng Heng <zengheng4@...wei.com>
> ---
>  fs/xfs/xfs_log.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 386b0307aed8..f6e7e4fd72ae 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -226,12 +226,12 @@ xlog_ticket_reservation(
>  	if (head == &log->l_write_head) {
>  		ASSERT(tic->t_flags & XLOG_TIC_PERM_RESERV);
>  		return tic->t_unit_res;
> -	} else {
> -		if (tic->t_flags & XLOG_TIC_PERM_RESERV)
> -			return tic->t_unit_res * tic->t_cnt;
> -		else
> -			return tic->t_unit_res;
>  	}
> +
> +	if (tic->t_flags & XLOG_TIC_PERM_RESERV)
> +		return tic->t_unit_res * tic->t_cnt;
> +
> +	return tic->t_unit_res;

I think this looks correct
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

>  }
>  
>  STATIC bool
> -- 
> 2.25.1
>