linux-kernel - Re: [PATCH 1/1] cgroup: Fix race condition at rebind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwUYfNEVIOyQXP8d@slm.duckdns.org>
Date:   Tue, 23 Aug 2022 08:12:12 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Jing-Ting Wu <Jing-Ting.Wu@...iatek.com>
Cc:     Michal Koutný <mkoutny@...e.com>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Jonathan.JMChen@...iatek.com, Lixiong.Liu@...iatek.com,
        wsd_upstream@...iatek.com, Wenju.Xu@...iatek.com,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/1] cgroup: Fix race condition at rebind_subsystems()

On Tue, Aug 23, 2022 at 01:41:46PM +0800, Jing-Ting Wu wrote:
> Root cause:
> The rebind_subsystems() is no lock held when move css object from A
> list to B list,then let B's head be treated as css node at
> list_for_each_entry_rcu().
> 
> Solution:
> Add grace period before invalidating the removed rstat_css_node.
> 
> Reported-by: Jing-Ting Wu <jing-ting.wu@...iatek.com>
> Suggested-by: Michal Koutný <mkoutny@...e.com>
> Signed-off-by: Jing-Ting Wu <jing-ting.wu@...iatek.com>
> Tested-by: Jing-Ting Wu <jing-ting.wu@...iatek.com>
> Link: https://lore.kernel.org/linux-arm-kernel/d8f0bc5e2fb6ed259f9334c83279b4c011283c41.camel@mediatek.com/T/

Applied to cgroup/for-6.0-fixes w/ stable tag added.

Thanks.

-- 
tejun