linux-kernel - Re: [PATCH] dt-bindings: leds: Add missing (unevaluated|additional)Properties on child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220823182756.GA13402@duo.ucw.cz>
Date:   Tue, 23 Aug 2022 20:27:57 +0200
From:   Pavel Machek <pavel@....cz>
To:     Rob Herring <robh@...nel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Vincent Knecht <vincent.knecht@...loo.org>,
        Nikita Travkin <nikitos.tr@...il.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Yi Xin <Yixin.zhu@...el.com>,
        Mallikarjuna reddy <mallikarjunax.reddy@...el.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        - NeilBrown <neilb@...e.de>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Add missing
 (unevaluated|additional)Properties on child nodes

Hi!

> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
>
> Signed-off-by: Rob Herring <robh@...nel.org>

Patch does way more than that:

Can we get some explanation why that's correct?

Best regards,
								Pavel

> index f8d7963c3a13..8b3b3bf1eaf2 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
> @@ -56,7 +56,8 @@ properties:
>  
>      patternProperties:
>        "^led@[0-2]$":
> -        type: object
> +        $ref: common.yaml#
> +        unevaluatedProperties: false
>  
>          properties:
>            reg:
> @@ -64,6 +65,9 @@ properties:
>              minimum: 0
>              maximum: 2
>  
> +          led-gpios:
> +            maxItems: 1
> +
>            intel,sso-hw-trigger:
>              type: boolean
>              description: This property indicates Hardware driven/control LED.
> @@ -118,14 +122,14 @@ examples:
>            reg = <0>;
>            function = "gphy";
>            color = <LED_COLOR_ID_GREEN>;
> -          led-gpio = <&ssogpio 0 0>;
> +          led-gpios = <&ssogpio 0 0>;
>          };
>  
>          led@2 {
>            reg = <2>;
>            function = LED_FUNCTION_POWER;
>            color = <LED_COLOR_ID_GREEN>;
> -          led-gpio = <&ssogpio 23 0>;
> +          led-gpios = <&ssogpio 23 0>;
>          };
>        };
>      };

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)