linux-kernel - Re: [PATCH] dt-bindings: leds: Add missing (unevaluated|additional)Properties on child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL6rQLkTkgaf-uyvjxtWLd++CZ1nXHrqDu3M7ybOs5i4Q@mail.gmail.com>
Date:   Wed, 24 Aug 2022 12:36:58 -0500
From:   Rob Herring <robh@...nel.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Vincent Knecht <vincent.knecht@...loo.org>,
        Nikita Travkin <nikitos.tr@...il.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Yi Xin <Yixin.zhu@...el.com>,
        Mallikarjuna reddy <mallikarjunax.reddy@...el.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        - NeilBrown <neilb@...e.de>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: leds: Add missing (unevaluated|additional)Properties
 on child nodes

On Tue, Aug 23, 2022 at 1:28 PM Pavel Machek <pavel@....cz> wrote:
>
> Hi!
>
> > In order to ensure only documented properties are present, node schemas
> > must have unevaluatedProperties or additionalProperties set to false
> > (typically).
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
>
> Patch does way more than that:

It only 'ensure only documented properties are present', but yeah, it
is sometimes more than just adding unevaluatedProperties.

> Can we get some explanation why that's correct?

...adds missing $ref if needed, and fixes resulting errors about
unevaluatedProperties.

BTW, these are just the simple ones. The led bindings with multi-led
nodes are more of a mess. I haven't decided exactly how to fix those.

Rob