[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE=gft48Tg6NnEUqfM-n1eOT3qa35dtowQGYCL3sbYBmr_Wm_w@mail.gmail.com>
Date: Wed, 24 Aug 2022 10:34:10 -0700
From: Evan Green <evgreen@...omium.org>
To: list.lkml.keyrings@...benboeckel.net
Cc: LKML <linux-kernel@...r.kernel.org>,
Gwendal Grignou <gwendal@...omium.org>,
Eric Biggers <ebiggers@...nel.org>,
Matthew Garrett <mgarrett@...ora.tech>,
Jarkko Sakkinen <jarkko@...nel.org>, zohar@...ux.ibm.com,
linux-integrity@...r.kernel.org, Pavel Machek <pavel@....cz>,
apronin@...omium.org, Daniil Lunev <dlunev@...gle.com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM <linux-pm@...r.kernel.org>,
Jonathan Corbet <corbet@....net>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
Matthew Garrett <matthewgarrett@...gle.com>,
Matthew Garrett <mjg59@...gle.com>,
David Howells <dhowells@...hat.com>,
James Morris <jmorris@...ei.org>,
Paul Moore <paul@...l-moore.com>,
"Serge E. Hallyn" <serge@...lyn.com>, keyrings@...r.kernel.org,
"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
linux-security-module@...r.kernel.org
Subject: Re: [PATCH v2 04/10] security: keys: trusted: Allow storage of PCR
values in creation data
On Wed, Aug 24, 2022 at 4:56 AM Ben Boeckel <me@...boeckel.net> wrote:
>
> On Tue, Aug 23, 2022 at 15:25:20 -0700, Evan Green wrote:
> > diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst
> > index 0bfb4c33974890..dc9e11bb4824da 100644
> > --- a/Documentation/security/keys/trusted-encrypted.rst
> > +++ b/Documentation/security/keys/trusted-encrypted.rst
> > @@ -199,6 +199,10 @@ Usage::
> > policyhandle= handle to an authorization policy session that defines the
> > same policy and with the same hash algorithm as was used to
> > seal the key.
> > + creationpcrs= hex integer representing the set of PCR values to be
> > + included in the PCR creation data. The bit corresponding
> > + to each PCR should be 1 to be included, 0 to be ignored.
> > + TPM2 only.
>
> There's inconsistent whitespace here. Given the context, I suspect the
> tabs should be expanded to spaces.
>
> As for the docs themselves, this might preferrably mention how large
> this is supposed to be. It seems to be limited to 32bits by the code.
> What happens if fewer are provided? More? Will there always be at most
> 32 PCR values? Also, how are the bits interpreted? I presume bit 0 is
> for PCR value 0?
Makes sense, I'll pin down the specification a bit better here and fix
up the spacing.
>
> Thanks for including docs.
Thanks for looking at them!
-Evan
Powered by blists - more mailing lists