linux-kernel - Re: [PATCH v3 1/7] dt-bindings: PCI: fu740-pci: fix missing clock-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwSFPwOkPIVC02fM@lpieralisi>
Date:   Tue, 23 Aug 2022 09:43:59 +0200
From:   Lorenzo Pieralisi <lpieralisi@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Conor Dooley <mail@...chuod.ie>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Rob Herring <robh+dt@...nel.org>,
        Albert Ou <aou@...s.berkeley.edu>,
        Palmer Dabbelt <palmer@...belt.com>,
        devicetree@...r.kernel.org, Greentime Hu <greentime.hu@...ive.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-riscv@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: PCI: fu740-pci: fix missing
 clock-names

On Mon, Aug 22, 2022 at 02:20:32PM -0500, Rob Herring wrote:
> On Sat, 20 Aug 2022 00:14:10 +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@...rochip.com>
> > 
> > The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix
> > 'unevaluatedProperties' warnings") removed the clock-names property as
> > a requirement and from the example as it triggered unevaluatedProperty
> > warnings. dtbs_check was not able to pick up on this at the time, but
> > now can:
> > 
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@...000000: Unevaluated properties are not allowed ('clock-names' was unexpected)
> >         From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> > 
> > The property was already in use by the FU740 DTS and the clock must be
> > enabled. The Linux and FreeBSD drivers require the property to enable
> > the clocks correctly Re-add the property and its "clocks" dependency,
> > while making it required.
> > 
> > Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings")
> > Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller")
> > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> > ---
> > v2022.08 of dt-schema is required.
> > ---
> >  .../devicetree/bindings/pci/sifive,fu740-pcie.yaml        | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

Should I pick these bindings updates up ?

Lorenzo