linux-kernel - RE: [PATCH v2] dmaengine: idxd: avoid deadlock in process_misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6097988CC9C2C1C713E3D8339B739@IA1PR11MB6097.namprd11.prod.outlook.com>
Date:   Wed, 24 Aug 2022 21:11:59 +0000
From:   "Yu, Fenghua" <fenghua.yu@...el.com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "Zhu, Tony" <tony.zhu@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: RE: [PATCH v2] dmaengine: idxd: avoid deadlock in
 process_misc_interrupts()

Hi, Jerry,

> I see another potential issue. If a software reset is attempted idxd_device_reinit()
> will be called which walks the wqs, and if a wq has the state
> IDXD_WQ_ENABLED it calls idxd_wq_enable(), but the first thing
> idxd_wq_enable() does is see that the state is IDXD_WQ_ENABLED and returns 0.
> Without the wq enable command being sent, it will not be re-enabled, yes?

Could you please describe how to reproduce the issues and test case?

Thanks.

-Fenghua