linux-kernel - Re: [next] x86: fs/hugetlbfs/inode.c:673:16: error: variable 'm_index' is uninitialized when used here [-Werror,-Wuninitialized]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ywee393cssPJ07Gr@dev-arch.thelio-3990X>
Date:   Thu, 25 Aug 2022 09:10:07 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Mike Kravetz <mike.kravetz@...cle.com>,
        linux-mm <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        open list <linux-kernel@...r.kernel.org>,
        regressions@...ts.linux.dev,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Muchun Song <songmuchun@...edance.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        David Hildenbrand <david@...hat.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        James Houghton <jthoughton@...gle.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Michal Hocko <mhocko@...e.com>,
        Mina Almasry <almasrymina@...gle.com>,
        Naoya Horiguchi <naoya.horiguchi@...ux.dev>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Peter Xu <peterx@...hat.com>,
        Prakash Sangappa <prakash.sangappa@...cle.com>,
        llvm@...ts.linux.dev
Subject: Re: [next] x86: fs/hugetlbfs/inode.c:673:16: error: variable
 'm_index' is uninitialized when used here [-Werror,-Wuninitialized]

Hi Naresh,

On Thu, Aug 25, 2022 at 04:13:30PM +0530, Naresh Kamboju wrote:
> The x86_64 and i386 clang builds failed due to these warnings / errors
> on Linux next-20220825.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> 
> fs/hugetlbfs/inode.c:673:16: error: variable 'm_index' is
> uninitialized when used here [-Werror,-Wuninitialized]
>                                                 m_start, m_index, truncate_op);
>                                                          ^~~~~~~
> fs/hugetlbfs/inode.c:651:26: note: initialize the variable 'm_index'
> to silence this warning
>         pgoff_t m_start, m_index;
>                                 ^
>                                  = 0
> 1 error generated.

Thank you for the report! Commit fcc0d3d00d74 ("hugetlb: handle truncate
racing with page faults") introduced this warning; the Intel folks
caught this as well:

https://lore.kernel.org/202208251012.g1mOhhxy-lkp@intel.com/

As an aside, can you please update your contact for our mailing list to
llvm@...ts.linux.dev? We do not use the Google Groups list anymore.

Cheers,
Nathan