lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Aug 2022 12:10:12 -0400 From: Alex Deucher <alexdeucher@...il.com> To: Bernard Zhao <bernard@...o.com> Cc: Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com>, "Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Nicholas Kazlauskas <nicholas.kazlauskas@....com>, Eric Yang <Eric.Yang2@....com>, Michael Strauss <michael.strauss@....com>, Fangzhi Zuo <Jerry.Zuo@....com>, Melissa Wen <mwen@...lia.com>, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, zhaojunkui2008@....com Subject: Re: [PATCH] drm/amd: fix potential memory leak On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@...o.com> wrote: > > This patch fix potential memory leak (clk_src) when function run > into last return NULL. > > Signed-off-by: Bernard Zhao <bernard@...o.com> > --- > drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > index 85f32206a766..76f263846c6b 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create( > } > > BREAK_TO_DEBUGGER(); > + free(clk_src); This should be kfree(). Fixed up locally. Alex > return NULL; > } > > -- > 2.33.1 >
Powered by blists - more mailing lists