linux-kernel - Re: [PATCH v5 1/5] gpio-f7188x: Add GPIO support for Nuvoton NCT6116

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2022 12:56:48 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Henning Schild <henning.schild@...mens.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Pavel Machek <pavel@....cz>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lee Jones <lee@...nel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Sheng-Yuan Huang <syhuang3@...oton.com>,
        Tasanakorn Phaipool <tasanakorn@...il.com>,
        simon.guinot@...uanux.org
Subject: Re: [PATCH v5 1/5] gpio-f7188x: Add GPIO support for Nuvoton NCT6116

On Thu, Aug 25, 2022 at 12:32 PM Henning Schild
<henning.schild@...mens.com> wrote:
> Am Wed, 24 Aug 2022 18:59:17 +0300
> schrieb Andy Shevchenko <andy.shevchenko@...il.com>:
> > On Wed, Aug 24, 2022 at 5:04 PM Henning Schild
> > <henning.schild@...mens.com> wrote:

...

> > > +#define gpio_dir_invert(type)  ((type) == nct6116d)
> > > +#define gpio_data_single(type) ((type) == nct6116d)
> >
> > What you are trying to do here is to put GPIO maintainers / heavy
> > contributors on a minefield (basically moving your job to their
> > shoulders). Please, provide a proper namespace and not gpio_ one. I'm
> > talking in my "GPIO heavy contributor" hat on.
>
> No i was trying to avoid having to touch those other 4 existing macros,
> touching lines that checkpatch.pl and you will pick on again. Adding
> the prefixes just to those new ones would be inconsistent and also not
> nice.

Do you have other prefixes in those files starting with gpio_?!
Now I see it. I'm not sure why this pops up only now.

> > With that fixed I can survive w/o pr_fmt() being in this patch. If you
> > are going to address this, you may add my tag in a new version.
>
> It is a bit unfortunate that you seem to be surprised where i said i
> was going to not address this.

Yes, because you are not a newbie and you know that the community
doesn't work on a "take it or leave" basis.

>  And once the new series comes insist on
> another round ... which involves testing and what not.

Which is your job as a developer.

> But hey, i will send a v6 with style refactoring patches and test it
> all over again.

Thanks!

> Thanks everyone for the review, i hope that next version will be
> acceptable and not open new discussion with the new patches coming.

-- 
With Best Regards,
Andy Shevchenko