linux-kernel - Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd2c9ca1-5ff6-3c45-fc10-90167c413061@linaro.org>
Date:   Fri, 26 Aug 2022 20:40:13 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Huqiang Qin <huqiang.qin@...ogic.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, narmstrong@...libre.com,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h

On 26/08/2022 15:23, Huqiang Qin wrote:
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
> 
> e.g.
>   * Bluetooth enable pin:
>     bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
>   * Audio mute pin:
>     spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
>   * ...

Then the header should be added when the need is implemented. Do not add
unused headers to files.

Best regards,
Krzysztof