linux-kernel - Re: [PATCH -next 1/3] remoteproc: qcom: wcss: check return value after calling platform_get_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63f86e67-23ce-0c53-e2dd-d7937584508b@quicinc.com>
Date:   Fri, 26 Aug 2022 11:03:18 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>
CC:     <agross@...nel.org>, <bjorn.andersson@...aro.org>
Subject: Re: [PATCH -next 1/3] remoteproc: qcom: wcss: check return value
 after calling platform_get_resource_byname()



On 8/26/2022 7:15 AM, Yang Yingliang wrote:
> If platform_get_resource_byname() fails, 'res' will be set to null pointer,
> it will cause null-ptr-deref when it used in devm_ioremap(), so we need check
> the return value.
> 
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>   drivers/remoteproc/qcom_q6v5_wcss.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
> index bb0947f7770e..017ee225dc32 100644
> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
> @@ -827,6 +827,8 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss,
>   	int ret;
>   
>   	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qdsp6");
> +	if (!res)
> +		return -EINVAL;

LGTM.

Reviewed-by:Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh

>   	wcss->reg_base = devm_ioremap(&pdev->dev, res->start,
>   				      resource_size(res));
>   	if (!wcss->reg_base)