linux-kernel - Re: [PATCH -next 2/3] remoteproc: qcom: wcss: Use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f00975d-8900-f03a-45d9-546d222ac450@quicinc.com>
Date:   Fri, 26 Aug 2022 11:06:08 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>
CC:     <agross@...nel.org>, <bjorn.andersson@...aro.org>
Subject: Re: [PATCH -next 2/3] remoteproc: qcom: wcss: Use
 devm_platform_ioremap_resource_byname()



On 8/26/2022 7:15 AM, Yang Yingliang wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>   drivers/remoteproc/qcom_q6v5_wcss.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
> index 017ee225dc32..209fc1bd1424 100644
> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
> @@ -835,8 +835,7 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss,
>   		return -ENOMEM;
>   
>   	if (wcss->version == WCSS_IPQ8074) {
> -		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rmb");
> -		wcss->rmb_base = devm_ioremap_resource(&pdev->dev, res);
> +		wcss->rmb_base = devm_platform_ioremap_resource_byname(pdev, "rmb");

LGTM.

Reviewed-by:Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh


>   		if (IS_ERR(wcss->rmb_base))
>   			return PTR_ERR(wcss->rmb_base);
>   	}