linux-kernel - Re: [PATCH net-next v2] net: phy: micrel: Make the GPIO to be non-exclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220827065838.7iw3cubgtzhwqc53@soft-dev3-1.localhost>
Date:   Sat, 27 Aug 2022 08:58:38 +0200
From:   Horatiu Vultur <horatiu.vultur@...rochip.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Andrew Lunn <andrew@...n.ch>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <hkallweit1@...il.com>,
        <linux@...linux.org.uk>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>, <michael@...le.cc>,
        <UNGLinuxDriver@...rochip.com>, <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v2] net: phy: micrel: Make the GPIO to be
 non-exclusive

The 08/26/2022 18:37, Jakub Kicinski wrote:

Hi Jakub,

> 
> On Thu, 25 Aug 2022 22:16:31 +0200 Andrew Lunn wrote:
> > On Thu, Aug 25, 2022 at 10:14:47PM +0200, Horatiu Vultur wrote:
> > > The same GPIO line can be shared by multiple phys for the coma mode pin.
> > > If that is the case then, all the other phys that share the same line
> > > will failed to be probed because the access to the gpio line is not
> > > non-exclusive.
> > > Fix this by making access to the gpio line to be nonexclusive using flag
> > > GPIOD_FLAGS_BIT_NONEXCLUSIVE. This allows all the other PHYs to be
> > > probed.
> > >
> > > Fixes: 738871b09250ee ("net: phy: micrel: add coma mode GPIO")
> > > Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> >
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> The tree name switch in the subject compared to v1 is unintentional?

Yes I have switch it by mistake.
It should be net. I can send a new version if it is needed.

-- 
/Horatiu