linux-kernel - Re: [PATCH v2] mm: deduplicate cacheline padding code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220826183553.4b923552ccddb07f0a78ac8b@linux-foundation.org>
Date:   Fri, 26 Aug 2022 18:35:53 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Shakeel Butt <shakeelb@...gle.com>
Cc:     Michal Hocko <mhocko@...nel.org>, Feng Tang <feng.tang@...el.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: deduplicate cacheline padding code

On Fri, 26 Aug 2022 23:06:42 +0000 Shakeel Butt <shakeelb@...gle.com> wrote:

> There are three users (mmzone.h, memcontrol.h, page_counter.h) using
> similar code for forcing cacheline padding between fields of different
> structures. Dedup that code.
> 
> ...
> 
>  include/linux/cache.h        | 13 +++++++++++++
>  include/linux/memcontrol.h   | 13 ++-----------
>  include/linux/mmzone.h       | 24 +++++-------------------
>  include/linux/page_counter.h | 13 ++-----------

I'm looking for an obvious and reliable way in which those three
headers include cache.h.  Seems that mm_types.h's inclusion of cache.h
should be sufficient.  Direct inclusion of cache.h would of course be
safest.  I guess if it breaks, we'll hear about it ;)