linux-kernel - Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220827184529.x6f7vacuhypaq7bb@pali>
Date:   Sat, 27 Aug 2022 20:45:29 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

On Saturday 27 August 2022 20:41:59 Andrew Lunn wrote:
> On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> > Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> > 
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> > Signed-off-by: Pali Rohár <pali@...nel.org>
> > ---
> >  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f655e9229d68..8215ffb6a795 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -463,7 +463,17 @@
> >  				};
> >  			};
> >  
> > -			/* port 6 is connected to eth0 */
> > +			ports@6 {
> > +				reg = <6>;
> > +				label = "cpu";
> > +				ethernet = <&eth0>;
> > +				phy-mode = "rgmii-id";
> > +
> > +				fixed-link {
> > +					speed = <1000>;
> > +					full-duplex;
> > +				};
> > +			};
> 
> Hi Pali
> 
> I've not been following Vladimirs work on multiple CPU ports. Is it
> clearly defined, both for old and new kernels, what happens where
> there are multiple CPU ports defined?
> 
>       Andrew

Hello!

On older kernel kernel versions just the first one cpu port works. Like
if second node is not defined at all. So I sent this patch to have
complete HW definition in DTS, even when kernel does not support all
features yet.