linux-kernel - Re: [PATCH v1] drivers/clk/clk: check return value of clk_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208290728.M8AblulP-lkp@intel.com>
Date:   Mon, 29 Aug 2022 07:26:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Li Zhong <floridsleeves@...il.com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, mturquette@...libre.com, sboyd@...nel.org,
        lily <floridsleeves@...il.com>
Subject: Re: [PATCH v1] drivers/clk/clk: check return value of
 clk_pm_runtime_get()

Hi Li,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linus/master v6.0-rc2 next-20220826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Zhong/drivers-clk-clk-check-return-value-of-clk_pm_runtime_get/20220829-042043
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: riscv-randconfig-r042-20220828 (https://download.01.org/0day-ci/archive/20220829/202208290728.M8AblulP-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/26ebbe49c7b40cb8465ed2bba4e4e62c3a55bb93
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Li-Zhong/drivers-clk-clk-check-return-value-of-clk_pm_runtime_get/20220829-042043
        git checkout 26ebbe49c7b40cb8465ed2bba4e4e62c3a55bb93
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/clk/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/clk/clk.c: In function 'clk_summary_show_subtree':
>> drivers/clk/clk.c:3014:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
    3014 |     if (ret)
         |     ^~
   drivers/clk/clk.c:3016:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    3016 |         clk_summary_show_one(s, c, level);
         |         ^~~~~~~~~~~~~~~~~~~~


vim +/if +3014 drivers/clk/clk.c

  3006	
  3007	static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
  3008					     int level)
  3009	{
  3010		struct clk_core *child;
  3011		int ret;
  3012		
  3013		ret = clk_pm_runtime_get(c);
> 3014	    if (ret)
  3015	        return;
  3016		clk_summary_show_one(s, c, level);
  3017		clk_pm_runtime_put(c);
  3018	
  3019		hlist_for_each_entry(child, &c->children, child_node)
  3020			clk_summary_show_subtree(s, child, level + 1);
  3021	}
  3022	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp