linux-kernel - Re: [PATCH v1] drivers/clk/clk: check return value of clk_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2022 08:18:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Li Zhong <floridsleeves@...il.com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        mturquette@...libre.com, sboyd@...nel.org,
        lily <floridsleeves@...il.com>
Subject: Re: [PATCH v1] drivers/clk/clk: check return value of
 clk_pm_runtime_get()

Hi Li,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linus/master v6.0-rc3 next-20220826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Zhong/drivers-clk-clk-check-return-value-of-clk_pm_runtime_get/20220829-042043
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arm-randconfig-r034-20220829 (https://download.01.org/0day-ci/archive/20220829/202208290820.mUMIcCS2-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project a2100daf12fb980a29fd1a9c85ccf8eaaaf79730)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/26ebbe49c7b40cb8465ed2bba4e4e62c3a55bb93
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Li-Zhong/drivers-clk-clk-check-return-value-of-clk_pm_runtime_get/20220829-042043
        git checkout 26ebbe49c7b40cb8465ed2bba4e4e62c3a55bb93
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/clk/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/clk/clk.c:3016:2: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
           clk_summary_show_one(s, c, level);
           ^
   drivers/clk/clk.c:3014:5: note: previous statement is here
       if (ret)
       ^
   1 warning generated.


vim +/if +3016 drivers/clk/clk.c

89ac8d7ae1cde0 Mike Turquette 2013-08-21  3006  
4dff95dc9477a3 Stephen Boyd   2015-04-30  3007  static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
4dff95dc9477a3 Stephen Boyd   2015-04-30  3008  				     int level)
4dff95dc9477a3 Stephen Boyd   2015-04-30  3009  {
4dff95dc9477a3 Stephen Boyd   2015-04-30  3010  	struct clk_core *child;
26ebbe49c7b40c lily           2022-08-28  3011  	int ret;
b2476490ef1113 Mike Turquette 2012-03-15  3012  	
26ebbe49c7b40c lily           2022-08-28  3013  	ret = clk_pm_runtime_get(c);
26ebbe49c7b40c lily           2022-08-28  3014      if (ret)
26ebbe49c7b40c lily           2022-08-28  3015          return;
4dff95dc9477a3 Stephen Boyd   2015-04-30 @3016  	clk_summary_show_one(s, c, level);
1bb294a7981c73 Taniya Das     2021-12-20  3017  	clk_pm_runtime_put(c);
0e1c03017549a9 Viresh Kumar   2012-04-11  3018  
4dff95dc9477a3 Stephen Boyd   2015-04-30  3019  	hlist_for_each_entry(child, &c->children, child_node)
4dff95dc9477a3 Stephen Boyd   2015-04-30  3020  		clk_summary_show_subtree(s, child, level + 1);
b2476490ef1113 Mike Turquette 2012-03-15  3021  }
b2476490ef1113 Mike Turquette 2012-03-15  3022  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp