linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: k3-am64-main: Enable crypto accelerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnapsu49.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Tue, 30 Aug 2022 19:37:02 +0530
From:   Kamlesh Gurudasani <kamlesh@...com>
To:     Jayesh Choudhary <j-choudhary@...com>, <nm@...com>,
        <vigneshr@...com>, <devicetree@...r.kernel.org>
CC:     <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <j-choudhary@...com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am64-main: Enable crypto
 accelerator

Jayesh Choudhary <j-choudhary@...com> writes:

> From: Peter Ujfalusi <peter.ujfalusi@...com>
>
> Add the node for SA2UL.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> [s-anna@...com: drop label, minor cleanups]
> Signed-off-by: Suman Anna <s-anna@...com>
> [j-choudhary@...com: disable rng-node, change flag to shared]
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index ada00575f0f2..06fada0d82b1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -1308,4 +1308,24 @@
>  		interrupt-names = "int0", "int1";
>  		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>  	};
> +
> +	crypto: crypto@...00000 {
> +		compatible = "ti,am64-sa2ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		power-domains = <&k3_pds 133 TI_SCI_PD_SHARED>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> +		dmas = <&main_pktdma 0xc001 0>, <&main_pktdma 0x4002 0>,
> +		       <&main_pktdma 0x4003 0>;
> +		dma-names = "tx", "rx1", "rx2";
> +
> +		rng: rng@...10000 {
> +			compatible = "inside-secure,safexcel-eip76";
> +			reg = <0x00 0x40910000 0x00 0x7d>;
> +			interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&k3_clks 133 0>;
> +			status = "disabled"; /* Used by OP-TEE */
> +		};
> +	};
>  };

Both patches look good to me.

Reviewed-by: Kamlesh Gurudasani <kamlesh@...com>