linux-kernel - Re: [PATCH v2] checksyscalls: Ignore fstat to silence build warning on LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H7zLOm-=vnKkOW8E8TNOr79GGJ1kP0nH8_1Ksh1MxTesw@mail.gmail.com>
Date:   Tue, 30 Aug 2022 10:59:14 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     WANG Xuerui <kernel@...0n.name>, Arnd Bergmann <arnd@...db.de>,
        loongarch@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] checksyscalls: Ignore fstat to silence build warning
 on LoongArch

Hi, Tiezhu,

On Tue, Aug 30, 2022 at 10:50 AM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> fstat is replaced by statx on the new architecture, so an exception
> is added to the checksyscalls script to silence the following build
> warning on LoongArch:
>
>   CALL    scripts/checksyscalls.sh
> <stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]
>
> Suggested-by: WANG Xuerui <kernel@...0n.name>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>
> Hi Xuerui and Arnd,
>
> Thank you for your reviews and suggestions.
>
> v2:
>   -- Change scripts/checksyscalls.sh
>   -- Modify patch subject and commit message
>
>  scripts/checksyscalls.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index f33e61a..c0a093c 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -114,7 +114,6 @@ cat << EOF
>  #define __IGNORE_truncate
>  #define __IGNORE_stat
>  #define __IGNORE_lstat
> -#define __IGNORE_fstat
>  #define __IGNORE_fcntl
>  #define __IGNORE_fadvise64
>  #define __IGNORE_newfstatat
> @@ -253,6 +252,7 @@ cat << EOF
>  #define __IGNORE_vserver
>
>  /* 64-bit ports never needed these, and new 32-bit ports can use statx */
I think the comment here should be modified to reflect the new fact,
and I think all syscalls controlled by __ARCH_WANT_NEW_STAT should be
listed.

Huacai

> +#define __IGNORE_fstat
>  #define __IGNORE_fstat64
>  #define __IGNORE_fstatat64
>  EOF
> --
> 2.1.0
>
>