linux-kernel - Re: [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive upper bound of toptiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAPL-u9HDu4Kk23S+mTueCfnHG7ujQJH5zqgkwmyAN52et26SA@mail.gmail.com>
Date:   Tue, 30 Aug 2022 08:48:22 -0700
From:   Wei Xu <weixugc@...gle.com>
To:     "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>
Cc:     Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Huang Ying <ying.huang@...el.com>,
        Yang Shi <shy828301@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Tim C Chen <tim.c.chen@...el.com>,
        Michal Hocko <mhocko@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hesham Almatary <hesham.almatary@...wei.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Alistair Popple <apopple@...dia.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Johannes Weiner <hannes@...xchg.org>, jvgediya.oss@...il.com,
        Bharata B Rao <bharata@....com>
Subject: Re: [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive
 upper bound of toptiers

On Tue, Aug 30, 2022 at 1:15 AM Aneesh Kumar K.V
<aneesh.kumar@...ux.ibm.com> wrote:
>
> Based on suggestion from Wei Xu <weixugc@...gle.com>, having an
> inclusive upper bound is found simpler.
>
> Fixes: mm/demotion: Update node_is_toptier to work with memory tiers
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com>
> ---
>  mm/memory-tiers.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index c4bd6d052a33..c82eb0111383 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -179,7 +179,7 @@ bool node_is_toptier(int node)
>                 toptier = true;
>                 goto out;
>         }
> -       if (memtier->adistance_start < top_tier_adistance)
> +       if (memtier->adistance_start <= top_tier_adistance)
>                 toptier = true;
>         else
>                 toptier = false;
> @@ -361,7 +361,8 @@ static void establish_demotion_targets(void)
>                          * abstract distance below the max value of this memtier

below -> up to ?  Looks good to me otherwise.

Wei

>                          * is considered toptier.
>                          */
> -                       top_tier_adistance = memtier->adistance_start + MEMTIER_CHUNK_SIZE;
> +                       top_tier_adistance = memtier->adistance_start +
> +                                               MEMTIER_CHUNK_SIZE - 1;
>                         break;
>                 }
>         }
> --
> 2.37.2
>