linux-kernel - Re: [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6baa55b4-b9d3-d28a-a2df-78e8b2200b00@siemens.com>
Date:   Wed, 31 Aug 2022 17:03:23 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     <pngliu@...mail.com>, <kbingham@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <linux-kernel@...r.kernel.org>, Peng Liu <liupeng17@...ovo.com>,
        "Stephen Boyd" <swboyd@...omium.org>
Subject: Re: [PATCH 3/3] scripts/gdb: fix lx-timerlist for
 HRTIMER_MAX_CLOCK_BASES printing

On 20.07.22 14:27, pngliu@...mail.com wrote:
> From: Peng Liu <liupeng17@...ovo.com>
> 
> HRTIMER_MAX_CLOCK_BASES is of enum type hrtimer_base_type. To print
> it as an integer, HRTIMER_MAX_CLOCK_BASES should be converted first.
> 
> Signed-off-by: Peng Liu <liupeng17@...ovo.com>
> ---
>  scripts/gdb/linux/timerlist.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 8281da068c5b..249f0e804b24 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -188,7 +188,8 @@ class LxTimerList(gdb.Command):
>          max_clock_bases = gdb.parse_and_eval("HRTIMER_MAX_CLOCK_BASES")
>  
>          text = "Timer List Version: gdb scripts\n"
> -        text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(max_clock_bases)
> +        text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(
> +            max_clock_bases.type.fields()[max_clock_bases].enumval)
>          text += "now at {} nsecs\n".format(ktime_get())
>  
>          for cpu in cpus.each_online_cpu():

Reviewed-by: Jan Kiszka <jan.kiszka@...mens.com>

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux