linux-kernel - Re: [PATCH v3 08/19] dt-bindings: hwmon: (mr75203) add "moortec, vm-active-channels" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6667978-3d26-945f-4bb7-e54f819211fc@amazon.com>
Date:   Wed, 31 Aug 2022 22:55:52 +0300
From:   "Farber, Eliav" <farbere@...zon.com>
To:     Rob Herring <robh@...nel.org>
CC:     <almogbs@...zon.com>, Rahul Tanwar <rtanwar@...linear.com>,
        Talel Shenhar <talel@...zon.com>,
        Linux HWMON List <linux-hwmon@...r.kernel.org>,
        <itamark@...zon.com>, <amitlavi@...zon.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jonathan Chocron <jonnyc@...zon.com>,
        Philipp Zabel <p.zabel@...gutronix.de>, <shellykz@...zon.com>,
        Jean Delvare <jdelvare@...e.com>, <shorer@...zon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <dkl@...zon.com>,
        "Hanoch, Uri" <hanochu@...zon.com>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        "Hawa, Hanna" <hhhawa@...zon.com>,
        "Krupnik, Ronen" <ronenk@...zon.com>,
        "Farber, Eliav" <farbere@...zon.com>
Subject: Re: [PATCH v3 08/19] dt-bindings: hwmon: (mr75203) add "moortec,
 vm-active-channels" property

On 8/31/2022 10:19 PM, Rob Herring wrote:
> On Wed, Aug 31, 2022 at 12:48 PM Farber, Eliav <farbere@...zon.com> 
> wrote:
>>
>> On 8/31/2022 3:17 PM, Rob Herring wrote:
>> > On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@...zon.com> 
>> wrote:
>> >>
>> >> On 8/31/2022 2:39 PM, Rob Herring wrote:
>> >>
>> >> On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote:
>> >>
>> >> Add optional "moortec,vm-active-channels" property to define the 
>> number
>> >> of active channels per VM.
>> >>
>> >> This shall be useful to avoid exposing sysfs for reading inputs 
>> that are
>> >> not connected to any voltage source.
>> >>
>> >> Signed-off-by: Eliav Farber <farbere@...zon.com>
>> >> ---
>> >> V3 -> V2:
>> >> - Add "moortec" prefix to property name.
>> >> - Add explanation why this change is needed.
>> >>
>> >>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++
>> >>  1 file changed, 11 insertions(+)
>> >>
>> >>
>> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m 
>> dt_binding_check'
>> >> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>> >>
>> >> I used dt_binding_check on my changes (I ported it to my kernel).
>> >> The error is related to "intel-vm-map" which I did not add.
>> >
>> > The error is the vendor prefix is not defined in vendor-prefixes.yaml.
>>
>> I fixed the vendor prefix error (will be part of v4).
>>
>> >> I don't mind fixing it if you wish.
>> >> It requires changing:
>> >>   intel,vm-map = [03 01 04 ff ff];
>> >> to:
>> >>   intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>;
>> >
>> > That is not the issue. The issue is the type is unknown because your
>> > schema fails and we can't get the type from it. Once your schema
>> > passes, this should go away.
>> Even after fixing the vendor prefix error I still see this:
>> moortec,mr75203.yaml: ignoring, error in schema: properties: 
>> intel,vm-map
>
> You still have an error in the schema. You should see a more specific
> reason before this message. 

Thanks, I found the problem.
I'm using an old version, and I'm missing this commit you did:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml?h=v6.0-rc3&id=d69c6ddd019f31081cc0232fa8ad8ea1cabdf22c