linux-kernel - Re: [PATCH v3 05/19] hwmon: (mr75203) skip reset-control deassert for SOCs that don't support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89b82aeeb613543642274623cedd71b682974a2d.camel@pengutronix.de>
Date:   Wed, 31 Aug 2022 10:19:03 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Eliav Farber <farbere@...zon.com>, jdelvare@...e.com,
        linux@...ck-us.net, robh+dt@...nel.org, rtanwar@...linear.com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     talel@...zon.com, hhhawa@...zon.com, jonnyc@...zon.com,
        hanochu@...zon.com, ronenk@...zon.com, itamark@...zon.com,
        shellykz@...zon.com, shorer@...zon.com, amitlavi@...zon.com,
        almogbs@...zon.com, dkl@...zon.com, rahul.tanwar@...ux.intel.com,
        andriy.shevchenko@...el.com
Subject: Re: [PATCH v3 05/19] hwmon: (mr75203) skip reset-control deassert
 for SOCs that don't support it

Hi Eliav,

On Di, 2022-08-30 at 19:21 +0000, Eliav Farber wrote:
> Don't fail the probe function and don't deassert the reset controller if
> a "reset" property doesn't exist in the device tree.
> 
> Change is done for SOCs that don't support a reset controller.

Not strictly related to this patch, but reading the context I wonder
whether it is required that clock/reset are running/deasserted all the
time. Would it make sense to implement some kind of runtime PM?

> Signed-off-by: Eliav Farber <farbere@...zon.com>

This change is

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp