linux-kernel - Re: [RFC PATCH] blk-mq: change bio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75f53b8f-30cd-23c3-1602-34d858302751@linux.alibaba.com>
Date:   Wed, 31 Aug 2022 08:42:42 +0800
From:   Liu Song <liusong@...ux.alibaba.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline


On 2022/8/30 21:59, Jens Axboe wrote:
> On 8/30/22 3:45 AM, Liu Song wrote:
>> From: Liu Song <liusong@...ux.alibaba.com>
>>
>> Change "bio_set_ioprio" to inline to avoid calling overhead.
> Let's not try to 2nd guess the compiler here. Most things that are
> marked inline should not be.
Agree, I think there is something wrong with the commit log written here,
it should be expected to reduce the call overhead, bio_set_ioprio seems
to be appropriate to use inline.

Thanks

>