linux-kernel - Re: [RFC PATCH] blk-mq: change bio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d81db7ff-6c5a-ff8c-ca1e-6d08474c202b@linux.alibaba.com>
Date:   Wed, 31 Aug 2022 08:48:49 +0800
From:   Liu Song <liusong@...ux.alibaba.com>
To:     Chaitanya Kulkarni <chaitanyak@...dia.com>
Cc:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline

On 2022/8/30 20:48, Chaitanya Kulkarni wrote:

> On 8/30/22 02:45, Liu Song wrote:
>> From: Liu Song <liusong@...ux.alibaba.com>
>>
>> Change "bio_set_ioprio" to inline to avoid calling overhead.
>>
>> Signed-off-by: Liu Song <liusong@...ux.alibaba.com>
> for performance overhead please provide quantitative data
>
> -ck
>
This is a small adjustment, and even if performance comparison data is 
obtained
for targeted design use cases, it is not universal. If the inline by the 
compiler is
successful, the number of instructions will be reduced.

Thanks

>