linux-kernel - Re: [PATCH] audit: remove obvious unnecessary header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhSPdD_tJYhynK=a3JcuU-2ez1S2VCUXLu0DJbWCn0-8zQ@mail.gmail.com>
Date:   Tue, 30 Aug 2022 20:49:03 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     chi wu <wuchi.zero@...il.com>
Cc:     eparis@...hat.com, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove obvious unnecessary header files

On Tue, Aug 30, 2022 at 8:20 PM chi wu <wuchi.zero@...il.com> wrote:
> Paul Moore <paul@...l-moore.com> 于2022年8月31日周三 01:04写道：
> >
> >
> > Hi Wuchi, can you explain what process you used to determine that
> > these header file includes were unnecessary?
>
> When reading the code, if I don't found the user of the *.h in the *.c
> file,I will think that is unnecessary. For example, #include
> <linux/kthread.h> in the audit.c, I don't found the use of kthread* in
> the file.
> But, I just build that without "W=1 " , the after test robot show that I
> was wrong. and I don't sure that if it is true to remove some header
> files.

Yes, I would recommend that you focus your time and energy on other
tasks within the Linux Kernel.  I'm very happy to see patches which
improve the audit subsystem, but I don't believe verifying the header
file usage is a good use of time at this point.

-- 
paul-moore.com