linux-kernel - Re: [PATCH] audit: remove obvious unnecessary header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+tQmHDoGjLsq74cifBpe1LvpN3MKYW0O5J9pX=vh4VVHoir8w@mail.gmail.com>
Date:   Wed, 31 Aug 2022 08:20:24 +0800
From:   chi wu <wuchi.zero@...il.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     eparis@...hat.com, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove obvious unnecessary header files

Paul Moore <paul@...l-moore.com> 于2022年8月31日周三 01:04写道：
>
>
> Hi Wuchi, can you explain what process you used to determine that
> these header file includes were unnecessary?

When reading the code, if I don't found the user of the *.h in the *.c
file,I will think that is unnecessary. For example, #include
<linux/kthread.h> in the audit.c, I don't found the use of kthread* in
the file.
But, I just build that without "W=1 " , the after test robot show that I
was wrong. and I don't sure that if it is true to remove some header
files.

thanks
wuchi
>
> --
> paul-moore.com