linux-kernel - Re: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function for register reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 17:20:10 -0700
From:   Badhri Jagan Sridharan <badhri@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        USB <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kyle Tso <kyletso@...gle.com>
Subject: Re: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function
 for register reads

Thanks for the feedback ! Brain fade moment of not including commit message.
Not exporting symbols anymore and I have squashed the patch as well into
"[PATCH v2 3/3] usb: typec: maxim_contaminant: Implement
check_contaminant callback"
which I just sent out.

On Tue, Aug 30, 2022 at 6:00 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Fri, Aug 26, 2022 at 01:40:00AM -0700, Badhri Jagan Sridharan wrote:
> > Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>
>
> As Heikki pointed out, I can not accept changes with no changelog text
> at all, you know this.
>
> Please write a good changelog text that explains why you are doing this
> so we can properly review it.  As it is, we have no idea what is going
> on here at all.
>
> thanks,
>
> greg k-h