linux-kernel - Re: [PATCH 3/5] gpio: pca953x: Fix pca953x_gpio_set_pull_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYvPKfvoFdMQYCjOWZYXpygkc_nWNFV0-zCCbx7=xGcPA@mail.gmail.com>
Date:   Wed, 31 Aug 2022 14:35:49 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Martyn Welch <martyn.welch@...labora.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>, kernel@...labora.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] gpio: pca953x: Fix pca953x_gpio_set_pull_up_down()

On Mon, Aug 29, 2022 at 3:39 PM Martyn Welch <martyn.welch@...labora.com> wrote:

> A previous fix (dc87f6dd058a gpio: pca953x: Fix pca953x_gpio_set_config)
> identified that pinconf_to_config_param() needed to be used to isolate
> the config_param from the pinconf in pca953x_gpio_set_config(). This fix
> however did not consider that this would also be needed in
> pca953x_gpio_set_pull_up_down() to which it passes this config.
>
> Perform a similar call in pca953x_gpio_set_pull_up_down() to isolate the
> configuration parameter there as well, rather than passing it from
> pca953x_gpio_set_config() as the configuration argument may also be needed
> in pca953x_gpio_set_pull_up_down() at a later date.
>
> Signed-off-by: Martyn Welch <martyn.welch@...labora.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij