linux-kernel - Re: [PATCH 4/5] gpio: pca953x: Swap if statements to save later complexity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaPa0CbF2r9RbDnC5oEVdt4vM7O9xg3Y30dekJs3wuwEA@mail.gmail.com>
Date:   Wed, 31 Aug 2022 14:36:37 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Martyn Welch <martyn.welch@...labora.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>, kernel@...labora.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] gpio: pca953x: Swap if statements to save later complexity

On Mon, Aug 29, 2022 at 3:39 PM Martyn Welch <martyn.welch@...labora.com> wrote:

> A later patch in the series adds support for a further chip type that
> shares some similarity with the PCA953X_TYPE. In order to keep the logic
> simple, swap over the if and else portions where checks are made against
> PCA953X_TYPE and instead check for PCA957X_TYPE.
>
> Signed-off-by: Martyn Welch <martyn.welch@...labora.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij