linux-kernel - RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for the quad-uart function in the multi-function endpoint of pci1xxxx device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR11MB36681DAF0F396AA407323A0AE97B9@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Thu, 1 Sep 2022 14:09:25 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <geert@...ux-m68k.org>
CC:     <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <ilpo.jarvinen@...ux.intel.com>, <andy.shevchenko@...il.com>,
        <u.kleine-koenig@...gutronix.de>, <johan@...nel.org>,
        <wander@...hat.com>, <etremblay@...tech-controls.com>,
        <macro@...am.me.uk>, <jk@...abs.org>, <phil.edworthy@...esas.com>,
        <lukas@...ner.de>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for
 the quad-uart function in the multi-function endpoint of pci1xxxx device.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Wednesday, August 31, 2022 1:28 AM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@...rochip.com>
> Cc: Greg KH <gregkh@...uxfoundation.org>; Jiri Slaby <jirislaby@...nel.org>;
> Ilpo Jarvinen <ilpo.jarvinen@...ux.intel.com>; Andy Shevchenko
> <andy.shevchenko@...il.com>; Uwe Kleine-König <u.kleine-
> koenig@...gutronix.de>; Johan Hovold <johan@...nel.org>;
> wander@...hat.com; etremblay@...tech-controls.com; Maciej W. Rozycki
> <macro@...am.me.uk>; Jeremy Kerr <jk@...abs.org>; Phil Edworthy
> <phil.edworthy@...esas.com>; Lukas Wunner <lukas@...ner.de>; Linux
> Kernel Mailing List <linux-kernel@...r.kernel.org>; open list:SERIAL DRIVERS
> <linux-serial@...r.kernel.org>; UNGLinuxDriver
> <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for
> the quad-uart function in the multi-function endpoint of pci1xxxx device.
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Kumaravel,
> 
> On Tue, Aug 30, 2022 at 8:01 PM Kumaravel Thiagarajan
> <kumaravel.thiagarajan@...rochip.com> wrote:
> > pci1xxxx is a PCIe switch with a multi-function endpoint on one of its
> > downstream ports. Quad-uart is one of the functions in the
> > multi-function endpoint. This driver loads for the quad-uart and
> > enumerates single or multiple instances of uart based on the PCIe
> > subsystem device ID.
> >
> > Signed-off-by: Kumaravel Thiagarajan
> > <kumaravel.thiagarajan@...rochip.com>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c
> 
> > +static struct pci_driver pci1xxxx_pci_driver = {
> > +       .name           = "pci1xxxx serial",
> > +       .probe          = pci1xxxx_serial_probe,
> > +       .remove = pci1xxxx_serial_remove,
> > +       .id_table       = pci1xxxx_pci_tbl,
> > +};
> > +
> > +module_pci_driver(pci1xxxx_pci_driver);
> 
> > --- a/drivers/tty/serial/8250/Kconfig
> > +++ b/drivers/tty/serial/8250/Kconfig
> > @@ -528,6 +528,15 @@ config SERIAL_8250_TEGRA
> >           Select this option if you have machine with an NVIDIA Tegra SoC and
> >           wish to enable 8250 serial driver for the Tegra serial interfaces.
> >
> > +config SERIAL_8250_PCI1XXXX
> > +       tristate "Microchip 8250 based serial port"
> > +       depends on SERIAL_8250
> 
> As this is a PCI driver, I guess it should depend on PCI (|| COMPILE_TEST)?
Ok. I will review this and modify as required.

> 
> > +       help
> > +        Select this option if you have a setup with Microchip PCIe
> > +        Switch with serial port enabled and wish to enable 8250
> > +        serial driver for the serial interface. This driver support
> > +        will ensure to support baud rates upto 1.5Mpbs.
> 

Thank You.

Regards,
Kumaravel