linux-kernel - RE: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power management functions to pci1xxxx's quad-uart driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR11MB3668B198D4BB4E86FC3519C0E97B9@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Thu, 1 Sep 2022 13:49:26 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <andy.shevchenko@...il.com>
CC:     <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <ilpo.jarvinen@...ux.intel.com>, <u.kleine-koenig@...gutronix.de>,
        <johan@...nel.org>, <wander@...hat.com>,
        <etremblay@...tech-controls.com>, <macro@...am.me.uk>,
        <geert+renesas@...der.be>, <jk@...abs.org>,
        <phil.edworthy@...esas.com>, <lukas@...ner.de>,
        <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power
 management functions to pci1xxxx's quad-uart driver.

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Wednesday, August 31, 2022 1:26 AM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@...rochip.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Jiri Slaby
> <jirislaby@...nel.org>; Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Johan Hovold
> <johan@...nel.org>; Wander Lairson Costa <wander@...hat.com>; Eric
> Tremblay <etremblay@...tech-controls.com>; Maciej W. Rozycki
> <macro@...am.me.uk>; Geert Uytterhoeven <geert+renesas@...der.be>;
> Jeremy Kerr <jk@...abs.org>; Phil Edworthy <phil.edworthy@...esas.com>;
> Lukas Wunner <lukas@...ner.de>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>; open list:SERIAL DRIVERS <linux-
> serial@...r.kernel.org>; UNGLinuxDriver
> <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power
> management functions to pci1xxxx's quad-uart driver.
> 
> 
> On Tue, Aug 30, 2022 at 9:01 PM Kumaravel Thiagarajan
> <kumaravel.thiagarajan@...rochip.com> wrote:
> >
> > pci1xxxx's quad-uart function has the capability to wake up the host
> > from suspend state. Enable wakeup before entering into suspend and
> > disable wakeup upon resume.
> 
> on resume
Ok. I will modify this.

> 
> ...
> 
> First of all, we have pm_ptr() and pm_sleep_ptr() with corresponding other
> macros in pm.h. Use them.
> Second, if you need to duplicate a lot of code from 8250_pci, split that code
> to 8250_pcilib.c and use it in the driver.
Ok. I will review and get back to you.

Thank You.

Regards,
Kumaravel