linux-kernel - RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for the quad-uart function in the multi-function endpoint of pci1xxxx device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63f48d1-f716-5040-c8d1-486087bd1c5e@linux.intel.com>
Date:   Thu, 1 Sep 2022 16:41:48 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Kumaravel.Thiagarajan@...rochip.com
cc:     andy.shevchenko@...il.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        u.kleine-koenig@...gutronix.de, johan@...nel.org,
        wander@...hat.com, etremblay@...tech-controls.com,
        macro@...am.me.uk, geert+renesas@...der.be, jk@...abs.org,
        phil.edworthy@...esas.com, Lukas Wunner <lukas@...ner.de>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        UNGLinuxDriver@...rochip.com
Subject: RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver
 for the quad-uart function in the multi-function endpoint of pci1xxxx
 device.

On Thu, 1 Sep 2022, Kumaravel.Thiagarajan@...rochip.com wrote:

> > > +       const unsigned int standard_baud_list[] = {50, 75, 110, 134, 150, 300,
> > > +                                               600, 1200, 1800, 2000, 2400, 3600,
> > > +                                               4800, 7200, 9600, 19200, 38400, 57600,
> > > +                                               115200, 125000, 136400, 150000, 166700,
> > > +                                               187500, 214300, 250000, 300000, 375000,
> > > +                                               500000, 750000,
> > > + 1000000, 1500000};
> > 
> > Why?!
>
> The standard baud rates are handled within serial8250_do_set_termios 
> which is invoked from within mchp_pci1xxxx_set_termios in first place. 
> Hence if it matches with any of the standard baudrates,
> it can return immediately.

Care to explain why the baudrates in your table don't match those in 
tty_baudrate.c? ...It makes no sense to me that you call these "standard 
baud rates".


-- 
 i.