linux-kernel - Re: [PATCH] drm: Simplify testing on UML with kunit.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220901144909.6rihfj4mgklk3ddf@nostramo.hardline.pl>
Date:   Thu, 1 Sep 2022 16:49:09 +0200
From:   Michał Winiarski <michal.winiarski@...el.com>
To:     Maxime Ripard <maxime@...no.tech>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-doc@...r.kernel.org>,
        <linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        David Gow <davidgow@...gle.com>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Jonathan Corbet <corbet@....net>, Helge Deller <deller@....de>,
        José Expósito <jose.exposito89@...il.com>
Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py

On Thu, Sep 01, 2022 at 04:02:53PM +0200, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Sep 01, 2022 at 03:36:21PM +0200, Michał Winiarski wrote:
> > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in
> > IOMEM and DMA emulation on UML.
> > Since --kconfig_add usage is no longer needed, remove it from
> > documentation.
> > 
> > Signed-off-by: Michał Winiarski <michal.winiarski@...el.com>
> > ---
> >  Documentation/gpu/drm-internals.rst | 7 +------
> >  drivers/video/Kconfig               | 4 ++++
> >  2 files changed, 5 insertions(+), 6 deletions(-)
> > 
> > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
> > index 5fd20a306718..c264a9587d21 100644
> > --- a/Documentation/gpu/drm-internals.rst
> > +++ b/Documentation/gpu/drm-internals.rst
> > @@ -228,16 +228,11 @@ follows:
> >  
> >  .. code-block:: bash
> >  
> > -	$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \
> > -		--kconfig_add CONFIG_VIRTIO_UML=y \
> > -		--kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> > +	$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests
> >  
> >  .. note::
> >  	The configuration included in ``.kunitconfig`` should be as generic as
> >  	possible.
> > -	``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> > -	included in it because they are only required for User Mode Linux.
> > -
> 
> I'm all for removing that part of the documentation, but because
> 6fc3a8636a7b, in 6.0 should address this entirely? Why would we need
> that other symbol?

We don't. I wasn't aware that 6fc3a8636a7b exists and had this one in my tree
prior to 6.0.
(well... technically we do need those other symbols and don't need VIRTIO, but
since CONFIG_UML_PCI_OVER_VIRTIO pull in those two, it also works).
Since docs were not updated, I didn't see any conflicts when rebasing.

Sorry for the noise, please ignore this patch.

-Michał

> 
> Maxime