linux-kernel - Re: [PATCH v3 2/2] virt: vbox: Remove unproper information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cf9b1f8-96c5-3d4d-d922-96dc1ef69d10@redhat.com>
Date:   Thu, 1 Sep 2022 16:49:05 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, gregkh@...uxfoundation.org
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] virt: vbox: Remove unproper information

Hi,

On 9/1/22 16:46, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the vbg_info() should be removed.
> 
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>  drivers/virt/vboxguest/vboxguest_linux.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 6fc81347ae72..c47e62dc55da 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>  
>  	pci_set_drvdata(pci, gdev);
>  
> -	vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
> -		 gdev->misc_device.minor, pci->irq, gdev->io_port,
> -		 &mmio, &mmio_len);
> -
>  	return 0;
>  
>  err_unregister_misc_device_user: