[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Vcg79sZjv24DD3ZhYf9aC-zoEZ59gfagS1Jw1-GYhpQug@mail.gmail.com>
Date: Thu, 1 Sep 2022 20:47:36 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: John Garry <john.garry@...wei.com>
Cc: "xuwei (O)" <xuwei5@...ilicon.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Linuxarm <linuxarm@...wei.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
SoC Team <soc@...nel.org>,
Yang Yingliang <yangyingliang@...wei.com>
Subject: Re: [PATCH 5/5] bus: hisi_lpc: Use platform_device_register_full()
On Thu, Sep 1, 2022 at 2:37 PM John Garry <john.garry@...wei.com> wrote:
>
> The code to create the child platform device is essentially the same as
> what platform_device_register_full() does, so change over to use
> that same function to reduce duplication.
Thanks!
> drivers/bus/hisi_lpc.c | 70 ++++++++++++++++++++++--------------------
> 1 file changed, 36 insertions(+), 34 deletions(-)
Looking at the statistics I thought it was a scary "improvement", but...
...
> /* ipmi */
> {
> .hid = "IPI0001",
> - .name = "hisi-lpc-ipmi",
> + .pdevinfo = (struct platform_device_info []) {
> + {
> + .parent = hostdev,
> + .fwnode = acpi_fwnode_handle(child),
> +
> + .name = "hisi-lpc-ipmi",
> + .id = PLATFORM_DEVID_AUTO,
> +
> + .res = res,
> + .num_res = num_res,
> + },
...here and in the other cases you have a lot of blank lines, can we
just get rid of them?
> + },
> },
> /* 8250-compatible uart */
> {
> .hid = "HISI1031",
> - .name = "serial8250",
> - .pdata = (struct plat_serial8250_port []) {
> + .pdevinfo = (struct platform_device_info []) {
> {
> - .iobase = res->start,
> - .uartclk = 1843200,
> - .iotype = UPIO_PORT,
> - .flags = UPF_BOOT_AUTOCONF,
> + .parent = hostdev,
> + .fwnode = acpi_fwnode_handle(child),
> +
> + .name = "serial8250",
> + .id = PLATFORM_DEVID_AUTO,
> +
> + .res = res,
> + .num_res = num_res,
> +
> + .data = (struct plat_serial8250_port []) {
> + {
> + .iobase = res->start,
> + .uartclk = 1843200,
> + .iotype = UPIO_PORT,
> + .flags = UPF_BOOT_AUTOCONF,
> + },
> + {}
> + },
> + .size_data = 2 *
> + sizeof(struct plat_serial8250_port),
I believe this can be one line.
> },
> },
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists