linux-kernel - Re: [PATCH 5/5] bus: hisi_lpc: Use platform_device_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6ded6f5-7132-e6e3-1f91-12deeb3b12ff@huawei.com>
Date:   Fri, 2 Sep 2022 07:46:33 +0100
From:   John Garry <john.garry@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "xuwei (O)" <xuwei5@...ilicon.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linuxarm <linuxarm@...wei.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        SoC Team <soc@...nel.org>,
        Yang Yingliang <yangyingliang@...wei.com>
Subject: Re: [PATCH 5/5] bus: hisi_lpc: Use platform_device_register_full()

On 01/09/2022 18:47, Andy Shevchenko wrote:
>> +                                       .name = "hisi-lpc-ipmi",
>> +                                       .id = PLATFORM_DEVID_AUTO,
>> +
>> +                                       .res = res,
>> +                                       .num_res = num_res,
>> +                               },
> ...here and in the other cases you have a lot of blank lines, can we
> just get rid of them?

ok

> 
>> +                       },
>>                  },
>>                  /* 8250-compatible uart */
>>                  {
>>                          .hid = "HISI1031",
>> -                       .name = "serial8250",
>> -                       .pdata = (struct plat_serial8250_port []) {
>> +                       .pdevinfo = (struct platform_device_info []) {
>>                                  {
>> -                                       .iobase = res->start,
>> -                                       .uartclk = 1843200,
>> -                                       .iotype = UPIO_PORT,
>> -                                       .flags = UPF_BOOT_AUTOCONF,
>> +                                       .parent = hostdev,
>> +                                       .fwnode = acpi_fwnode_handle(child),
>> +
>> +                                       .name = "serial8250",
>> +                                       .id = PLATFORM_DEVID_AUTO,
>> +
>> +                                       .res = res,
>> +                                       .num_res = num_res,
>> +
>> +                                       .data = (struct plat_serial8250_port []) {
>> +                                               {
>> +                                                       .iobase = res->start,
>> +                                                       .uartclk = 1843200,
>> +                                                       .iotype = UPIO_PORT,
>> +                                                       .flags = UPF_BOOT_AUTOCONF,
>> +                                               },
>> +                                               {}
>> +                                       },
>> +                                       .size_data =  2 *
>> +                                               sizeof(struct plat_serial8250_port),
> I believe this can be one line.

I think so, as we're exceeding 80 char width anyway.

> 
>>                                  },

Thanks,
John