linux-kernel - Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdVqRyA=J0-HsHtgiAZhd8XxqxmMddTyV2u29TxvV9=Cw@mail.gmail.com>
Date:   Thu, 1 Sep 2022 22:38:40 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Cezary Rojewski <cezary.rojewski@...el.com>
Cc:     ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        amadeuszx.slawinski@...ux.intel.com,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input()

On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
<cezary.rojewski@...el.com> wrote:
>
> Make use of global user input tokenization helper instead of the
> internal one as both serve same purpose. With that, both strsplit_u32()

the same

> and tokenize_input() become unused so remove them.

...

>  #include <linux/debugfs.h>
>  #include <linux/module.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/string_helpers.h>

I believe either blank line needs to be here (to split the sound / SOF
group of headers) or this should be put after 'so*'-ones

>  #include <sound/soc.h>
>  #include <sound/sof/header.h>
>  #include "sof-client.h"

...

>         struct sof_probes_priv *priv = cdev->data;
>         struct device *dev = &cdev->auxdev.dev;
>         struct sof_probe_point_desc *desc;
> -       size_t num_tkns, bytes;
> -       u32 *tkns;
> +       size_t bytes;
> +       u32 num_tkns, *tkns;

I would expect a longer line first.

>         int ret, err;

...

With the above addressed
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko