linux-kernel - Re: [PATCH v3 1/2] lib/string_helpers: Introduce tokenize_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8a06f76-9414-6391-0582-667cf817dbcc@intel.com>
Date:   Fri, 2 Sep 2022 09:46:25 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        <amadeuszx.slawinski@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v3 1/2] lib/string_helpers: Introduce
 tokenize_user_input()

On 2022-09-01 9:34 PM, Andy Shevchenko wrote:
> On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
> <cezary.rojewski@...el.com> wrote:

...

>> +int tokenize_user_input(const char __user *from, size_t count, int **tkns);
> 
> Not sure how I can deduct from the name what function is actually
> doing. Suggested new name: int_array_parse_user().
> 
> int int_array_parse_user(const char __user *from, size_t count, int **array);
> 
> (Note that we have _user suffix for many APIs in the kernel that does
> interact with user space memory)


That's why I've added '_user_' in the middle! Anyway, I guess the 
expectation is that it's a suffix - precisely at the end of the name.

Could we reorder it a bit: "parse_int_array_user"?

>> + * @tkns:      Returned pointer to sequence of integers
> 
> array

Ack.

> If you are okay with this, you may add my
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
>