[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220901141257.07131439@kernel.org>
Date: Thu, 1 Sep 2022 14:12:57 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: menglong8.dong@...il.com
Cc: edumazet@...gle.com, davem@...emloft.net, pabeni@...hat.com,
rostedt@...dmis.org, mingo@...hat.com, imagedong@...cent.com,
dsahern@...nel.org, flyingpeng@...cent.com,
dongli.zhang@...cle.com, robh@...nel.org, asml.silence@...il.com,
luiz.von.dentz@...el.com, vasily.averin@...ux.dev,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: skb: export skb drop reaons to user by
TRACE_DEFINE_ENUM
On Thu, 1 Sep 2022 23:23:39 +0800 menglong8.dong@...il.com wrote:
> +#undef FN
> +#define FN(reason) [SKB_DROP_REASON_##reason] = #reason,
> +const char * const drop_reasons[] = {
> + DEFINE_DROP_REASON(FN, FN)
> +};
The undef looks a little backwards, no? We don't want to pollute all
users of skbuff.h with a FN define.
#define FN....
/* use it */
#undef FN
Powered by blists - more mailing lists