linux-kernel - Re: [PATCH net-next] net: skb: export skb drop reaons to user by TRACE_DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3bjafYdX0X8B+KFbKrgH0Cm5Th9F6V8SEi+KZJa95keaw@mail.gmail.com>
Date:   Fri, 2 Sep 2022 10:13:04 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     edumazet@...gle.com, davem@...emloft.net, pabeni@...hat.com,
        rostedt@...dmis.org, mingo@...hat.com, imagedong@...cent.com,
        dsahern@...nel.org, flyingpeng@...cent.com,
        dongli.zhang@...cle.com, robh@...nel.org, asml.silence@...il.com,
        luiz.von.dentz@...el.com, vasily.averin@...ux.dev,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM

On Fri, Sep 2, 2022 at 5:12 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu,  1 Sep 2022 23:23:39 +0800 menglong8.dong@...il.com wrote:
> > +#undef FN
> > +#define FN(reason) [SKB_DROP_REASON_##reason] = #reason,
> > +const char * const drop_reasons[] = {
> > +     DEFINE_DROP_REASON(FN, FN)
> > +};
>
> The undef looks a little backwards, no? We don't want to pollute all
> users of skbuff.h with a FN define.
>
> #define FN....
> /* use it */
> #undef FN

Okay, Thanks! I'll wait a moment to see if there are other comments
before sending the next version.

Menglong Dong