linux-kernel - Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220901063153.zutwnnfykaz47sah@vireshk-i7>
Date:   Thu, 1 Sep 2022 12:01:53 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Perry Yuan <Perry.Yuan@....com>
Cc:     rafael.j.wysocki@...el.com, ray.huang@....com,
        Deepak.Sharma@....com, Mario.Limonciello@....com,
        Nathan.Fontenot@....com, Alexander.Deucher@....com,
        Jinzhou.Su@....com, Shimmer.Huang@....com, Xiaojian.Du@....com,
        Li.Meng@....com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and
 duplicated headers declaration

On 01-09-22, 14:23, Perry Yuan wrote:
> Cleanup the headers declaration which are not used
> actually and 

This is okay.

> some duplicated declaration which is declarated in some
> other headers already, it will help to simplify the header part.

This isn't.

Every file should directly include headers they use definitions from,
instead of relying on indirect inclusions.

-- 
viresh