lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7fec6d15f69751422de1e20cf13b5a3f839da2d1.camel@linux.ibm.com>
Date:   Thu, 01 Sep 2022 14:43:31 +0530
From:   Tarun Sahu <tsahu@...ux.ibm.com>
To:     Axel Rasmussen <axelrasmussen@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>
Cc:     "Zach O'Keefe" <zokeefe@...gle.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        aneesh.kumar@...ux.ibm.com
Subject: Re: [PATCH] selftest: vm: remove orphaned references to
 local_config.{h,mk}

On Wed, 2022-08-31 at 14:15 -0700, Axel Rasmussen wrote:
> Note: this commit is intended to apply to mm-unstable, the commit
> being
> fixed only exists in that branch for now.
> 
> Commit b4efb234e53cc60ccdc855190be9f35918687412 ("Kselftests: remove
> support of libhugetlbfs from kselftests") removed the rule describing
> how to build local_config.{h,mk}, but it left two references to these
> files lingering around. The result is, none of the selftests could be
> built due to dependencies with no rule for how to build them.
> 
> Signed-off-by: Axel Rasmussen <axelrasmussen@...gle.com>
> ---
>  tools/testing/selftests/vm/Makefile | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/vm/Makefile
> b/tools/testing/selftests/vm/Makefile
> index b52f2cc51482..4ae879f70f4c 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -1,9 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Makefile for vm selftests
>  
> -LOCAL_HDRS += $(selfdir)/vm/local_config.h
> $(top_srcdir)/mm/gup_test.h
> -
> -include local_config.mk
> +LOCAL_HDRS += $(top_srcdir)/mm/gup_test.h
>  
>  uname_M := $(shell uname -m 2>/dev/null || echo not)
>  MACHINE ?= $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e
> 's/ppc64.*/ppc64/')

Thanks, Alex. When I looked why it built in my case, The local_config
was part of .gitignore which "git clean" ignored and they resided there
and source was built without any problem. 
I have submitted a new patch for updated .gitignore.



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ